Fix IRB container package #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandenburger
force-pushed
the
irb-fix
branch
from
015d700 to
1c31946
Compare
mbrandenburger
force-pushed
the
irb-fix
branch
17 times, most recently
from
776ccc6 to
c9451cc
Compare
munapower
reviewed
Apr 7, 2025
samples/demos/irb/Makefile
Outdated
| make -C ${FPC_PATH}/ercc all docker | ||
| $(DOCKER) image tag fpc/ercc:$(FPC_VERSION) fpc/ercc:latest | ||
|
|
||
| build: ercc |
Contributor
There was a problem hiding this comment.
if when you call build you execute ercc then why do you have it in all?
Contributor
Author
There was a problem hiding this comment.
good catch! Let me clean this up.
Contributor
Author
There was a problem hiding this comment.
I've updated the Makefile. Note that we call the all target implicitly via a make test as triggered from the root directory. This means that, we do not run the irb build target when we call make build from the root, thus, we lazy build irb only when we test it.
The irb build target does now everything to test the demo.
mbrandenburger
force-pushed
the
irb-fix
branch
2 times, most recently
from
cd501c7 to
61eb987
Compare
- implement docker API changes Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
munapower
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the IBR tests and fixes existing issues.